Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve screenshot-test performance #644

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

adrianjost
Copy link
Contributor

Description

  • Cherrypick from Feature/screenshot test crop screenshots to content #524
  • Moved the performance improvements into this PR so we can merge it earlier :D
  • parallize screenshot test execution. This also required renaming all screenshot files 😐 That's why there are so many files changed.
  • ~7min => ~3min
  • mocked all external images with base64 or repo internal Images

@pullapprove pullapprove bot added the waiting for review Someone should review this ASAP label Feb 18, 2020
@adrianjost adrianjost force-pushed the feature/screenshot-test-performance branch from eb6c2b3 to ab7e85b Compare February 18, 2020 17:40
@adrianjost adrianjost changed the title crop screenshots to content improve screenshot-test performance Feb 18, 2020
@hpi-schul-clud-bot
Copy link
Contributor

❤️ I have deployed this pull-request for you:

Docs: http://docs.644.nuxt.schul-cloud.surge.sh
Storybook: http://stories.644.nuxt.schul-cloud.surge.sh

@adrianjost adrianjost self-assigned this Feb 18, 2020
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #644 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #644   +/-   ##
========================================
  Coverage    84.62%   84.62%           
========================================
  Files           77       77           
  Lines          813      813           
  Branches       131      131           
========================================
  Hits           688      688           
  Misses         122      122           
  Partials         3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f72492...ab7e85b. Read the comment docs.

@adrianjost adrianjost merged commit e33af67 into develop Feb 18, 2020
@adrianjost adrianjost deleted the feature/screenshot-test-performance branch February 18, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for review Someone should review this ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants