-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite SocketPlugin to NIO #21
Conversation
Cool! Thanks a lot, will have a look soon! |
Codecov Report
@@ Coverage Diff @@
## dev #21 +/- ##
============================================
+ Coverage 52.13% 52.78% +0.65%
- Complexity 2454 2525 +71
============================================
Files 189 193 +4
Lines 17061 17069 +8
Branches 2403 2362 -41
============================================
+ Hits 8894 9010 +116
+ Misses 7231 7134 -97
+ Partials 936 925 -11
Continue to review full report at Codecov.
|
src/de.hpi.swa.graal.squeak/src/de/hpi/swa/graal/squeak/nodes/plugins/network/SqSocket.java
Outdated
Show resolved
Hide resolved
src/de.hpi.swa.graal.squeak/src/de/hpi/swa/graal/squeak/nodes/plugins/network/SqSocket.java
Outdated
Show resolved
Hide resolved
....swa.graal.squeak.test/src/de/hpi/swa/graal/squeak/test/AbstractSqueakTestCaseWithImage.java
Show resolved
Hide resolved
....swa.graal.squeak.test/src/de/hpi/swa/graal/squeak/test/AbstractSqueakTestCaseWithImage.java
Show resolved
Hide resolved
src/de.hpi.swa.graal.squeak/src/de/hpi/swa/graal/squeak/nodes/plugins/network/Resolver.java
Show resolved
Hide resolved
src/de.hpi.swa.graal.squeak/src/de/hpi/swa/graal/squeak/nodes/plugins/network/SocketPlugin.java
Outdated
Show resolved
Hide resolved
src/de.hpi.swa.graal.squeak/src/de/hpi/swa/graal/squeak/nodes/plugins/network/SqSocket.java
Outdated
Show resolved
Hide resolved
src/de.hpi.swa.graal.squeak/src/de/hpi/swa/graal/squeak/nodes/plugins/network/SqSocket.java
Outdated
Show resolved
Hide resolved
src/de.hpi.swa.graal.squeak/src/de/hpi/swa/graal/squeak/nodes/plugins/network/TCPSocket.java
Outdated
Show resolved
Hide resolved
src/de.hpi.swa.graal.squeak/src/de/hpi/swa/graal/squeak/nodes/plugins/network/UDPSocket.java
Outdated
Show resolved
Hide resolved
Use TruffleLogger
Use TruffleLogger in SocketPlugin
Use longs, swap Sq prefix to Squeak
PrimitiveFailed.andTransferToInterpreter
a2881ea
to
be97db6
Compare
be97db6
to
042209a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR
SocketTest
,SocketStreamTest
,SqueakSSLTest
,StringSocketTestCase
,WebClientServerTest
, ...