chore: use optional chaining (smithy-lang#1021)

hpmellema · Jun 16, 2023 · bef2242 · bef2242
1 parent 8dddece
commit bef2242
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/packages/fetch-http-handler/src/fetch-http-handler.ts b/packages/fetch-http-handler/src/fetch-http-handler.ts
@@ -36,11 +36,11 @@ export class FetchHttpHandler implements HttpHandler {
     request: HttpRequest,
     options: HttpHandlerOptions
   ): Promise<{ response: HttpResponse }> {
-    const abortSignal = options && options.abortSignal;
+    const abortSignal = options?.abortSignal;
     const requestTimeoutInMs = this.httpOptions.requestTimeout;
 
     // if the request was already aborted, prevent doing extra work
-    if (abortSignal && abortSignal.aborted) {
+    if (abortSignal?.aborted) {
       const abortError = new Error("Request aborted");
       abortError.name = "AbortError";
       return Promise.reject(abortError);

diff --git a/packages/middleware-retry/src/retryDecider.ts b/packages/middleware-retry/src/retryDecider.ts
@@ -31,5 +31,5 @@ export const defaultRetryDecider = (error: SdkError) => {
 };
 
 function hasMetadata(error: any): error is MetadataBearer {
-  return error && error.$metadata;
+  return error?.$metadata;
 }
diff --git a/packages/middleware-stack/src/MiddlewareStack.ts b/packages/middleware-stack/src/MiddlewareStack.ts
@@ -401,7 +401,7 @@ export class MiddlewareStack<Input extends object, Output extends object> {
         : defaultAnchorValue;
       let relativeEntry = prev;
       //reverse relative entry linked list and add to ordered handler list
-      while (relativeEntry && relativeEntry.prev) {
+      while (relativeEntry?.prev) {
         relativeEntry = relativeEntry.prev;
       }
       while (relativeEntry) {

diff --git a/packages/node-http-handler/src/node-http-handler.ts b/packages/node-http-handler/src/node-http-handler.ts
@@ -60,7 +60,7 @@ export class NodeHttpHandler implements HttpHandler {
   ): Promise<{ response: HttpResponse }> {
     return new Promise((resolve, reject) => {
       // if the request was already aborted, prevent doing extra work
-      if (abortSignal && abortSignal.aborted) {
+      if (abortSignal?.aborted) {
         const abortError = new Error("Request aborted");
         abortError.name = "AbortError";
         reject(abortError);

diff --git a/packages/node-http-handler/src/node-http2-handler.ts b/packages/node-http-handler/src/node-http2-handler.ts
@@ -46,7 +46,7 @@ export class NodeHttp2Handler implements HttpHandler {
   ): Promise<{ response: HttpResponse }> {
     return new Promise((resolve, reject) => {
       // if the request was already aborted, prevent doing extra work
-      if (abortSignal && abortSignal.aborted) {
+      if (abortSignal?.aborted) {
         const abortError = new Error("Request aborted");
         abortError.name = "AbortError";
         reject(abortError);

diff --git a/packages/property-provider/src/chain.ts b/packages/property-provider/src/chain.ts
@@ -17,7 +17,7 @@ export function chain<T>(...providers: Array<Provider<T>>): Provider<T> {
     );
     for (const provider of providers) {
       promise = promise.catch((err: any) => {
-        if (err && err.tryNextLink) {
+        if (err?.tryNextLink) {
           return provider();
         }
 

diff --git a/packages/signature-v4/src/getCanonicalHeaders.ts b/packages/signature-v4/src/getCanonicalHeaders.ts
@@ -18,7 +18,7 @@ export function getCanonicalHeaders(
     const canonicalHeaderName = headerName.toLowerCase();
     if (
       canonicalHeaderName in ALWAYS_UNSIGNABLE_HEADERS ||
-      (unsignableHeaders && unsignableHeaders.has(canonicalHeaderName)) ||
+      unsignableHeaders?.has(canonicalHeaderName) ||
       PROXY_HEADER_PATTERN.test(canonicalHeaderName) ||
       SEC_HEADER_PATTERN.test(canonicalHeaderName)
     ) {