Fix CPython 3.8 and 3.9 debug builds on CI #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What was the thing that broke? |
|
@hodgestar my understanding is that setuptools started using its own copy of distutils, which however relies on some CPython internal or semi public API that somehow does not work with the debug build. The distutils within CPython works. We'll probably have to revert this once they remove distutils from CPython for good, but then setuptools with its internl distutils copy should be hopefully working again... |
steve-s
changed the title
|
@hodgestar Ah I see I forgot to link this with the corresponding issue. |
|
Since I hope this is not very controversial and it re-enables CI checks that we've been ignoring for a while, which is not ideal, I'll go ahead with merging. |
|
@steve-s Thank you for the explanation & thank you for fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282