-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CPlusPlus support #321
Conversation
758a10e
to
3ba6e81
Compare
If it works I am all for this. Most of the changes look sane even for pure C codebase. But doesn't testing everything with (*) plus the C files that are currently compiled with the extension, but as we discussed in the meeting, we'd like to actually compile them ourselves, so in that case they'd be always compiled by C compiler too). |
Closes #318. In order to do this the PR:
The new CI run is passing. |
Would anyone else like to review or can this be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ping |
This PR has two approvals, can we merge it? |
🚀 |
The codebase did not support compiling with a c++ compiler. I also added a CI run for g++