Add structseq.c to extra sources. #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
reviewed
May 11, 2023
| % DEFAULT_HPY_ABI), | ||
| ('hpy-use-static-libs', None, 'Use static library containing context ' | ||
| 'and helper functions for building ' | ||
| 'extensions (default: False)') |
There was a problem hiding this comment.
Yes, I first called it hpy-no-static-libs but then we changed it to semantically do not use static libs by default. So, I renamed the attribute but didn't rename the option 😞 .
This just shows that everything that is not tested will eventually fail. I will also add some tests for this as soon as I find the time to do so.
|
LGTM, just trying to understand the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an important bug fix for HPy
0.9.0rc1(and I will createrc2after this is merged).When I've added the helper functions
HPyStructSequence_New/NewTypein PR #415 , I obviously forgot to add it to the list of extra sources inhpy.devel. This may result in an undefined symbol error when linking.It doesn't show up in the tests because we build a static lib containing the helpers and I did add the new source file to there (in
setup.py).In order to avoid such problems in future, I plan to have the list of helper sources just in one place.