Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Modifier parameter to BottomSheetHost #33

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

sebastianmarschall
Copy link
Contributor

Added Modifier to BottomShootHost, as discussed in #32

@hrach
Copy link
Owner

hrach commented Jul 22, 2024

Please, could you fix:

[standard:trailing-comma-on-call-site] Missing trailing comma before ")"
on two places.

Also, if you want, you may add the same to ModalSheetHost.
Thank you.

@sebastianmarschall
Copy link
Contributor Author

Hi @hrach,
fixed it. Regarding ModalSheetHost, there is a Modifier paramter already thats passed into AnimatedContent. I dont know the reason behind this and don't want to break anything.

@hrach hrach merged commit 07f7010 into hrach:main Jul 22, 2024
1 check passed
@hrach
Copy link
Owner

hrach commented Jul 22, 2024

Thank you 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants