Covariant return types for intersect methods #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrnsky
approved these changes
Oct 23, 2022
|
Looks good, thanks! |
|
Released as v4.0.1 - https://central.sonatype.dev/artifact/org.pcollections/pcollections/4.0.1 @prdoyle When you get a chance, perhaps you can check if this new release works as expected in your project, since it's packaged and published differently than before (thanks to #109) |
|
@hrldcpr - I checked. Worked as expected! |
|
@prdoyle Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
minusAllmethod is overridden in subtypes ofPSetso that it returns those particular subtypes.This PR does the same for
intersect.Implementation notes
The DRY principle would suggest that the subtypes should call the
superversion of the method. However, this would require a downcast. I opted instead to just duplicate the one-liner method implementation, but perhaps the downcast would be cleaner?