speed up OrderedPSet.minus() #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t() and indexOf() can't be efficient anymore, but they should probably have never been there in the first place, since the analogous class LinkedHashSet doesn't have them. increment major version since this is a breaking change
|
fyi @prdoyle last thing is to add an |
|
Oh wow, you already did #93. Never mind! |
prdoyle
reviewed
Sep 18, 2022
| if (contents.contains(e)) return this; | ||
| return new OrderedPSet<E>(contents.plus(e), order.plus(e)); | ||
| if (ids.containsKey(e)) return this; | ||
| final Long id = elements.isEmpty() ? -Long.MIN_VALUE : (elements.lastKey() + 1); |
There was a problem hiding this comment.
@hrldcpr -Long.MIN_VALUE equals just Long.MIN_VALUE due to overflow. But I think you meant MIN_VALUE anyway, so I suppose this "bug" is harmless?
There was a problem hiding this comment.
haha whoops, good find, thanks! I'm glad it still works but yeah that was definitely not what I intended
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #95
OrderedPSet.minus()was linear, so this makes it logarithmic, by switching from a vector to a map.Benchmarks shows no performance regression for other methods, while
ordered_pset_plus_minus_reverseis sped up significantly (and this is just for 1000 elements, for more elements the speedup would be even better):(Note these ops/s are actually thousands of operations per second.)
This change means
get()andindexOf()can't be efficient anymore, but they should probably have never been there in the first place, since the analogous class LinkedHashSet doesn't have them, so this removes them. Thus this is a breaking change, so it can be part of the upcoming major version release.Closes #95