Fixed memory leak of connection (apache#165)

Signed-off-by: xiaolong.ran <rxl@apache.org>
hrsakai · Jan 6, 2020 · e7b779c · e7b779c
1 parent 0a496cc
commit e7b779c
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pulsar/internal/connection_pool.go b/pulsar/internal/connection_pool.go
@@ -68,11 +68,13 @@ func (p *connectionPool) GetConnection(logicalAddr *url.URL, physicalAddr *url.U
 	}
 
 	// Try to create a new connection
-	newCnx, wasCached := p.pool.LoadOrStore(logicalAddr.Host,
-		newConnection(logicalAddr, physicalAddr, p.tlsOptions, p.connectionTimeout, p.auth))
+	newConnection := newConnection(logicalAddr, physicalAddr, p.tlsOptions, p.connectionTimeout, p.auth)
+	newCnx, wasCached := p.pool.LoadOrStore(logicalAddr.Host, newConnection)
 	cnx := newCnx.(*connection)
 	if !wasCached {
 		cnx.start()
+	} else {
+		newConnection.Close()
 	}
 
 	if err := cnx.waitUntilReady(); err != nil {