Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev #956

Merged
merged 14 commits into from
May 3, 2022
Merged

dev #956

merged 14 commits into from
May 3, 2022

Conversation

hrsh7th
Copy link
Owner

@hrsh7th hrsh7th commented May 2, 2022

No description provided.

hrsh7th and others added 4 commits May 3, 2022 03:41
Adjust empty line count
1466e57
@zer09
Implement vim.api.nvim_create_autocmd (#844)
b0896bf 
* Implement vim.api.nvim_create_autocmd

* Only use vim.api.nvim_create_autocmd on nighly

* Cleanup

* cleanup

* Rename autos.lua to autocmds.lua

* Fix forgot to rename autos to autocmds

* Remove legacy autocmd

* Add descriptions on autocmds

* Update descriptions on autocmds
@mehalter
Update CmpStatus command to lua API (#922)
a292926 
Signed-off-by: Micah Halter <micah@balena.io>
@mehalter
Move highlights to nvim_set_hl lua API (#925)
bda03c9 
Signed-off-by: Micah Halter <micah@balena.io>
@hrsh7th hrsh7th mentioned this pull request May 3, 2022
Open
@hrsh7th hrsh7th merged commit 5054c14 into main May 3, 2022
@hrsh7th hrsh7th deleted the dev branch May 3, 2022 16:47
@hermitmaster
Copy link

This commit broke my completion menu. Leaving insert mode doesn't make the completion menu disappear.

@hrsh7th hrsh7th mentioned this pull request May 3, 2022
Closed
2 tasks
@hrsh7th
Copy link
Owner Author

hrsh7th commented May 3, 2022

Thank you for reporting.
I would appreciate it if you could create an issue from the next time.

@hermitmaster
Copy link

Sorry, I meant to create an issue.

This was referenced May 3, 2022
Closed
Closed
@wookayin
Copy link
Contributor

wookayin commented May 12, 2022 •
edited
Loading

So starting from this commit 5054c14, nvim-cmp requires lua v0.7.0? Why don't you please mention something in #231 (or in README), or make some warning messages?

@smjonas
Copy link
Contributor

smjonas commented May 12, 2022 •
edited
Loading

Seems like it was announced in #231 (the edit from 9 days ago used the status: applied), but I agree it would be a better user experience if it was announced in the plugin itself as not every user is active on the repo

@wookayin
Copy link
Contributor

wookayin commented May 12, 2022 •
edited
Loading

Also, I think when this branch was merged, it should have NOT squashed all the commits (bda03c9, a292926, b0896bf) as each of these has individual scope of changeset that is worth retaining the history. Such long-spanning branch can be simply fast forwarded or merged by rebasing multiple commits. IMO I believe those workflow will make the commit history much more readable, searchable, and easy to troubleshoot than the current one (just says "dev" (#956)) with when something goes wrong.

@mcauley-penney mcauley-penney mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hrsh7th @hermitmaster @wookayin @smjonas @zer09 @mehalter