Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonic Rivals controls semi-broken #11878

Closed
hrydgard opened this issue Mar 11, 2019 · 3 comments
Closed

Sonic Rivals controls semi-broken #11878

hrydgard opened this issue Mar 11, 2019 · 3 comments
Labels
Input/Controller Input and controller issues
Milestone
v1.8.0

Comments

@hrydgard
Copy link
Owner

hrydgard commented Mar 11, 2019 •
edited
Loading

Holding down digital buttons doesn't work. Can still play somewhat using analog stick. Seems similar to #11798.
@hrydgard hrydgard added this to the v1.8.0 milestone Mar 11, 2019
@hrydgard
Copy link
Owner Author

Actually I probably haven't noticed this before because it's still somewhat playable with the analog stick, so the control bug seems a bit old... I'll track it down.

@hrydgard hrydgard added the Input/Controller Input and controller issues label Mar 12, 2019
@hrydgard
Copy link
Owner Author

hrydgard commented Mar 12, 2019 •
edited
Loading

Culprit for the control issue appears to be #11094 , or more specifically e69e844 . Reverting that commit fixes the issue (and likely the Rock Band issue as well).

@hrydgard
Copy link
Owner Author

I'm switching this over to just be the control bug, I'll create a separate one for rendering.

@hrydgard hrydgard changed the title Vulkan: Sonic Rivals broken on both Mali and Adreno Sonic Rivals controls semi-broken Mar 12, 2019
@hrydgard hrydgard mentioned this issue Mar 12, 2019
Closed
@hrydgard hrydgard removed the Vulkan label Mar 12, 2019
unknownbrackets added a commit that referenced this issue Mar 12, 2019
@unknownbrackets
Merge pull request #11879 from hrydgard/fix-ctrl-latch-bug
05ad393 
Fix apparent bug in #11094, fixes #11878 and likely #11798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Input/Controller Input and controller issues
Projects
None yet
Milestone
v1.8.0
Development

No branches or pull requests
1 participant
@hrydgard