Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix apparent bug in #11094, fixes #11878 and likely #11798 #11879

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Fix apparent bug in #11094, fixes #11878 and likely #11798 #11879

merged 1 commit into from
Mar 12, 2019

Conversation

hrydgard
Copy link
Owner

@unknownbrackets please take a look :)

@hrydgard hrydgard added this to the v1.8.0 milestone Mar 12, 2019
unknownbrackets
unknownbrackets approved these changes Mar 12, 2019
View reviewed changes
Copy link
Collaborator

@unknownbrackets unknownbrackets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be right, but it's strange that it still made the test pass... that said, now I'm not seeing a test fail even with the change reverted, and I didn't note which test it was.

-[Unknown]

@unknownbrackets unknownbrackets merged commit 05ad393 into master Mar 12, 2019
@hrydgard hrydgard deleted the fix-ctrl-latch-bug branch March 12, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unknownbrackets unknownbrackets unknownbrackets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hrydgard @unknownbrackets