Add compat flag / bug check for games on old Adreno/GL affected by #16015 #16422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
OpenGL
Confirmed Driver Bug
| @@ -186,6 +186,12 @@ u32 GPU_GLES::CheckGPUFeatures() const { | |||
| features |= GPU_USE_SINGLE_PASS_STEREO; | |||
| } | |||
|
|
|||
| if (draw_->GetBugs().Has(Draw::Bugs::ADRENO_RESOURCE_DEADLOCK)) { | |||
| if (PSP_CoreParameter().compat.flags().OldAdrenoPixelDepthRoundingGL) { | |||
| features |= GPU_ROUND_FRAGMENT_DEPTH_TO_16BIT; | |||
There was a problem hiding this comment.
CheckGPUFeaturesLate() might add another flag (like GPU_ROUND_DEPTH_TO_16BIT or GPU_SCALE_DEPTH_FROM_24BIT_TO_16BIT), not sure if this is really a problem or not, though. In theory those flags can coexist...
There was a problem hiding this comment.
Right, I'll re-order it to do it after CheckGPUFeatureLate, and also check for vendor workarounds.
ghost
reviewed
Nov 24, 2022
There was a problem hiding this comment.
- Forgot to add this games (OpenGL) Certain Games Crashes With ADRENO GPU 3xx and 5xx series #16015 (comment) in compat.ini
…6015 See #16015 Partly derived from master...unknownbrackets:ppsspp:adreno-deadlock But this one surgically activates it only for the known affected games, to avoid any additional performance regressions in the release. Entirely untested.
hrydgard
force-pushed
the
old-adreno-gl-compat-flag
branch
from
491ed12
to
9bc0d66
Compare
|
@Gamemulatorer Done! |
|
Yeah, that's a good idea. |
ghost
mentioned this pull request
|
This seems doesnt work correctly in adreno 306 I got freeze in Naruto Shippuden, Phantasy Star Portable 1 and 2 using my vivo y51a snapdragon 410. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #16015
Partly derived from master...unknownbrackets:ppsspp:adreno-deadlock
But this one surgically activates it only for the known affected games, to avoid any additional performance regressions in the release. Ugly, but not sure what else to do given the nebulous nature of the driver bug.
Entirely untested.