Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User reported 1.14 regressions #16638

Closed
hrydgard opened this issue Dec 21, 2022 · 11 comments
Closed

User reported 1.14 regressions #16638

hrydgard opened this issue Dec 21, 2022 · 11 comments
Milestone

Comments

@hrydgard
Copy link
Owner

hrydgard commented Dec 21, 2022

Been getting some emails and Discord messages reporting reduced performance or graphical glitches in some games in 1.14, collecting them here to maybe later split out into issues. I've added partial names so I can search my email for them without being too specific.

Naruto Ultimate Ninja Impact

For example, Sebastian reports that on a Huawei y5 2018 , he's got new graphical problems in Naruto Ultimate ninja impact. PowerVR GE8100.

FIFA "22"

Esethu reports that FIFA 22 (assuming one of those roster hacks) and Dragon Ball Z (unclear which game) has suddenly started crashing a lot on a "Samsung Android (latest version)".

Dante's Inferno

Performance regression, seems fillrate related (user can only detect performance loss at high resolutions) so likely some new passes are happening that didn't before (framebuffer reinterpret or similar). (yes, see below) See #17030

Toca Race Driver

The range culling issues are back on Mali. (Fixed)

Gran Turismo

Apparently it ran better on Galaxy A5 (android 7, adreno) in older versions.

Fate Unlimited Codes

image

This happens on D3D11 for some reason.

There are additional even less specific ones.

More as they arrive, maybe there are patterns.

@ghost
Copy link

ghost commented Dec 22, 2022

Toca Race Driver 2 is crashing using opengl backend only.
Screenshot_20221222_130447

ndException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:17.452  5355  5427 E PpssppActivity: openContentUri exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:17.459  5355  5427 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:17.465  5355  5427 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:27.895  6342  6342 E PpssppActivity: Got ACTION_VIEW without a valid uri, trying param
12-22 12:45:27.895  6342  6342 E PpssppActivity: Shortcut missing parameter!
12-22 12:45:28.977  6342  6342 E PpssppActivity: Got ACTION_VIEW without a valid uri, trying param
12-22 12:45:28.977  6342  6342 E PpssppActivity: Shortcut missing parameter!
12-22 12:45:32.924  6342  6342 E PpssppActivity: Got ACTION_VIEW without a valid uri, trying param
12-22 12:45:32.924  6342  6342 E PpssppActivity: Shortcut missing parameter!
12-22 12:45:33.286  6342  6342 E PPSSPPNativeActivity: updateSystemUiVisibility: decor view not yet created, ignoring for now
12-22 12:45:38.315  6342  6473 E PpssppActivity: openContentUri exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SYSTEM/compatvr.ini is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SYSTEM/compatvr.ini at /storage/3136-6161/PSP/SYSTEM/compatvr.ini
12-22 12:45:46.311  6342  6473 E PpssppActivity: openContentUri exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:46.320  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:46.328  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:47.128  6342  6473 E PpssppActivity: openContentUri exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:47.136  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:47.144  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:54.269  6342  6473 E PpssppActivity: openContentUri exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:54.278  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:54.286  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:55.286  6342  6473 E PpssppActivity: openContentUri exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:55.295  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:55.303  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:58.954  6342  6473 E PpssppActivity: openContentUri exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:58.977  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:58.986  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:58.995  6342  6473 E PpssppActivity: openContentUri exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:59.005  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:59.013  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/DATA.BIN at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/DATA.BIN
12-22 12:45:59.023  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000 is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000 at /storage/3136-6161/PSP/SAVEDATA/ULES000400000
12-22 12:45:59.031  6342  6473 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000 is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000 at /storage/3136-6161/PSP/SAVEDATA/ULES000400000
12-22 12:45:59.219  6342  7056 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000 is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000 at /storage/3136-6161/PSP/SAVEDATA/ULES000400000
12-22 12:45:59.229  6342  7056 E PpssppActivity: contentUriGetFileInfo exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000 is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000 at /storage/3136-6161/PSP/SAVEDATA/ULES000400000
12-22 12:45:59.364  6342  7056 E PpssppActivity: openContentUri exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SAVEDATA/ULES000400000/PARAM.SFO is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SAVEDATA/ULES000400000/PARAM.SFO at /storage/3136-6161/PSP/SAVEDATA/ULES000400000/PARAM.SFO
12-22 13:00:55.437  9740  9740 E PpssppActivity: Got ACTION_VIEW without a valid uri, trying param
12-22 13:00:55.437  9740  9740 E PpssppActivity: Shortcut missing parameter!
12-22 13:00:56.202  9740  9740 E PPSSPPNativeActivity: updateSystemUiVisibility: decor view not yet created, ignoring for now
12-22 13:00:57.202  9740  9740 E PpssppActivity: Got ACTION_VIEW without a valid uri, trying param
12-22 13:00:57.202  9740  9740 E PpssppActivity: Shortcut missing parameter!
12-22 13:00:57.211  9740  9740 E PPSSPPNativeActivity: updateSystemUiVisibility: decor view not yet created, ignoring for now
12-22 13:01:01.835  9740  9740 E PpssppActivity: Got ACTION_VIEW without a valid uri, trying param
12-22 13:01:01.835  9740  9740 E PpssppActivity: Shortcut missing parameter!
12-22 13:01:06.880  9740  9869 E PpssppActivity: openContentUri exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SYSTEM/compatvr.ini is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SYSTEM/compatvr.ini at /storage/3136-6161/PSP/SYSTEM/compatvr.ini
12-22 13:04:40.122 11844 11844 E PpssppActivity: Got ACTION_VIEW without a valid uri, trying param
12-22 13:04:40.122 11844 11844 E PpssppActivity: Shortcut missing parameter!
12-22 13:04:41.159 11912 11912 F DEBUG   : Softversion: PD1930CF_EX_A_6.8.55
12-22 13:04:41.160 11912 11912 F DEBUG   : Time: 2022-12-22 13:04:41
12-22 13:04:41.160 11912 11912 F DEBUG   : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
12-22 13:04:41.160 11912 11912 F DEBUG   : Build fingerprint: 'vivo/1906/1906:11/RP1A.200720.012/compiler0316164337:user/release-keys'
12-22 13:04:41.160 11912 11912 F DEBUG   : Revision: '0'
12-22 13:04:41.160 11912 11912 F DEBUG   : ABI: 'arm64'
12-22 13:04:41.160 11912 11912 F DEBUG   : Timestamp: 2022-12-22 13:04:41+0800
12-22 13:04:41.160 11912 11912 F DEBUG   : pid: 11844, tid: 11892, name: Emu  >>> org.ppsspp.ppsspp <<<
12-22 13:04:41.160 11912 11912 F DEBUG   : uid: 10275
12-22 13:04:41.160 11912 11912 F DEBUG   : signal 7 (SIGBUS), code 1 (BUS_ADRALN), fault addr 0x14b506c6d7836
12-22 13:04:41.160 11912 11912 F DEBUG   :     x0  000000757a1e3020  x1  0000000000000000  x2  0000000000000090  x3  0000000000000009
12-22 13:04:41.160 11912 11912 F DEBUG   :     x4  0000000000000000  x5  0000007522c95740  x6  0000000300000000  x7  0000000000001406
12-22 13:04:41.160 11912 11912 F DEBUG   :     x8  02014b506c6d782e  x9  02014b506c6d7836  x10 000000757a1e3028  x11 0000000000000000
12-22 13:04:41.160 11912 11912 F DEBUG   :     x12 000000757a1e0000  x13 00000000000000a0  x14 fffffffffc000000  x15 0000000003ffe000
12-22 13:04:41.160 11912 11912 F DEBUG   :     x16 0000007613d5a930  x17 0000007613d4f59c  x18 000000750eda8000  x19 000000757a1e3020
12-22 13:04:41.160 11912 11912 F DEBUG   :     x20 0000007510475a80  x21 0000007523b7a68d  x22 000000757a1e3078  x23 000000757a1e3030
12-22 13:04:41.160 11912 11912 F DEBUG   :     x24 0000007510476000  x25 0000007522c6acf0  x26 0000007522c6ad00  x27 02014b506c6d782e
12-22 13:04:41.160 11912 11912 F DEBUG   :     x28 e0e00b8a02210821  x29 0000007510475a60
12-22 13:04:41.160 11912 11912 F DEBUG   :     lr  000000752392c164  sp  0000007510475a10  pc  000000752392c204  pst 0000000080000000
12-22 13:04:41.178 11912 11912 F DEBUG   : backtrace:
12-22 13:04:41.178 11912 11912 F DEBUG   :       #00 pc 0000000000c54204  /data/app/~~nYZQkE5KyF1oesTEP4btVw==/org.ppsspp.ppsspp-x40wqStyZyrA3_XHagGp9A==/lib/arm64/libppsspp_jni.so (Draw::OpenGLContext::CreateGraphicsPipeline(Draw::PipelineDesc const&, char const*)+332) (BuildId: abf3ec7402719dac582a0d7e34e32107cfda4d1e)
12-22 13:04:41.178 11912 11912 F DEBUG   :       #01 pc 0000000000783e78  /data/app/~~nYZQkE5KyF1oesTEP4btVw==/org.ppsspp.ppsspp-x40wqStyZyrA3_XHagGp9A==/lib/arm64/libppsspp_jni.so (CreateGlobalPipelines()+400) (BuildId: abf3ec7402719dac582a0d7e34e32107cfda4d1e)
12-22 13:04:41.178 11912 11912 F DEBUG   :       #02 pc 0000000000783b2c  /data/app/~~nYZQkE5KyF1oesTEP4btVw==/org.ppsspp.ppsspp-x40wqStyZyrA3_XHagGp9A==/lib/arm64/libppsspp_jni.so (NativeInitGraphics(GraphicsContext*)+148) (BuildId: abf3ec7402719dac582a0d7e34e32107cfda4d1e)
12-22 13:04:41.178 11912 11912 F DEBUG   :       #03 pc 000000000077db08  /data/app/~~nYZQkE5KyF1oesTEP4btVw==/org.ppsspp.ppsspp-x40wqStyZyrA3_XHagGp9A==/lib/arm64/libppsspp_jni.so (BuildId: abf3ec7402719dac582a0d7e34e32107cfda4d1e)
12-22 13:04:41.178 11912 11912 F DEBUG   :       #04 pc 000000000043e514  /data/app/~~nYZQkE5KyF1oesTEP4btVw==/org.ppsspp.ppsspp-x40wqStyZyrA3_XHagGp9A==/lib/arm64/libppsspp_jni.so (void* std::__ndk1::__thread_proxy<std::__ndk1::tuple<std::__ndk1::unique_ptr<std::__ndk1::__thread_struct, std::__ndk1::default_delete<std::__ndk1::__thread_struct> >, void (*)()> >(void*)+44) (BuildId: abf3ec7402719dac582a0d7e34e32107cfda4d1e)
12-22 13:04:41.178 11912 11912 F DEBUG   :       #05 pc 00000000000f4510  /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+64) (BuildId: b1d7ec252d7b460a539cf3a520c06bb8)
12-22 13:04:41.179 11912 11912 F DEBUG   :       #06 pc 000000000008ef34  /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: b1d7ec252d7b460a539cf3a520c06bb8)
12-22 13:04:50.094 12035 12035 E PpssppActivity: Got ACTION_VIEW without a valid uri, trying param
12-22 13:04:50.094 12035 12035 E PpssppActivity: Shortcut missing parameter!
12-22 13:04:51.373 12035 12035 E PpssppActivity: Got ACTION_VIEW without a valid uri, trying param
12-22 13:04:51.373 12035 12035 E PpssppActivity: Shortcut missing parameter!
12-22 13:04:54.113 12035 12105 E PpssppActivity: openContentUri exception: java.lang.IllegalArgumentException: Failed to determine if 3136-6161:PSP/SYSTEM/compatvr.ini is child of 3136-6161:PSP: java.io.FileNotFoundException: Missing file for 3136-6161:PSP/SYSTEM/compatvr.ini at /storage/3136-6161/PSP/SYSTEM/compatvr.ini

@hrydgard hrydgard added this to the v1.14.2 milestone Dec 22, 2022
@ghost
Copy link

ghost commented Dec 22, 2022

I discover that Toca Race Driver series is also affected by #16015.
So adding this game id to [OldAdrenoPixelDepthRoundingGL] fixes the crash issue.

ghost referenced this issue Dec 22, 2022
…6015

See #16015

Partly derived from master...unknownbrackets:ppsspp:adreno-deadlock

But this one surgically activates it only for the known affected games, to avoid any additional
performance regressions in the release.

Entirely untested.
hrydgard added a commit that referenced this issue Dec 23, 2022
@hrydgard
Copy link
Owner Author

@Gamemulatorer Added.

@unknownbrackets
Copy link
Collaborator

I think some people have said GLES is slower than before, but I've started to suspect that maybe these people were using a speedhack that was either disabled by default again or removed. Interestingly, at least one person said Vulkan was a bit faster than before, but was less stable FPS wise than GLES.

-[Unknown]

@foundObjects
Copy link

foundObjects commented Dec 27, 2022

Just a heads up, this change (200c055) switching on "Retain changed textures" in compat.ini for Final Fantasy Tactics breaks some character stat drawing in the party screen.

I have to override it manually in PPSSPP/system/compat.ini or the stat display gets stuck and doesn't update when switching between characters using L and R, it's much worse when switching very quickly.

I'm on Android, but people on the FFT subreddit are seeing the same on Windows. v1.13.2 is unaffected up through git build v1.13.2-1801.

If it's helpful to see what's happening I have a couple of quick screen capture clips of the menu pre and post change.

@hrydgard
Copy link
Owner Author

Good discovery. I'm gonna back that change out, I don't know if it had enough performance benefit to motivate itself anyway.

@hrydgard
Copy link
Owner Author

hrydgard commented Dec 31, 2022

Looked at Dante's Inferno, as mentioned in #16327 , it does an effect that's very inefficient to emulate (texturing from the same image it's rendering to to perform a bloom effect). In 1.14, it's turned even more inefficient, since previously we were somehow able to (incorrectly in my opinion!) not do a new copy after every single draw call, instead it only happend after each little bunch of them drawing to the same location.

So we fixed a logical error but it got slower. To get back the old speed correctly we need to track modified rectangles of the current texture, only "re-copying" it to a source texture when we texture from a region the previous draw call modified. We have some limited tracking similar to that but not enough, I think.

@ghost
Copy link

ghost commented Jan 1, 2023

Using 1 or more post processing shaders can decrease performance in Tekken6.
Screenshot_20230101_135357_74c288e31530b9e5d0ca749a600f3e41
Screenshot_20230101_135040_74c288e31530b9e5d0ca749a600f3e41
ULES01376.ppdmp.zip

@hrydgard
Copy link
Owner Author

hrydgard commented Jan 1, 2023

@Gamemulatorer Well, post-shaders aren't free. Is it somehow worse in 1.14 than in 1.13?

@ghost
Copy link

ghost commented Jan 2, 2023

@Gamemulatorer Well, post-shaders aren't free. Is it somehow worse in 1.14 than in 1.13?

Using 1.14.3 version this issue of performance using shaders is ok now :)

@hrydgard
Copy link
Owner Author

The Dante and Toca issues are fixed, and the others are a bit nebulous and hard to reproduce. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants