Switch json to gason, include json writer in build #10960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
unknownbrackets
force-pushed
the
debugger-json
branch
from
f2b1817
to
3e9d181
Compare
unknownbrackets
force-pushed
the
debugger-json
branch
from
3e9d181
to
c1fc361
Compare
It doesn't support them. The common workaround is to use null.
From the same author. Most importantly, reads numbers as doubles rather than as signed ints and floats. This allows us to actually read 32 bit unsigned int parameters. Moved all the native customization to a separate json_reader.cpp.
unknownbrackets
force-pushed
the
debugger-json
branch
from
c1fc361
to
082ddf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For after 1.6.0, this is a decent chunk of #10909 that impacts behavior in a few different places (e.g. store, remote disc sharing, version check.)
Figure it's better to separate in case there are issues (will rebase #10909.)
The only behavior difference here should be slightly improved typesafety on some json parsing (e.g. before it assumed things were arrays or objects/dicts in some cases.)
-[Unknown]