Enable IPv6 for reporting / sharing / etc. #11004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Oh @hrydgard when the dust settles for 1.6.x can you try this on one of those older devices? I'm worried it might not load the dll properly prior to Android 4.x, almost forgot. If so... I guess that means a ppsspp_net so? Eventually sceNet should probably move to ipv6 too... -[Unknown] |
|
For what it's worth, this starts up and talks to the PPSSPP Homebrew Store just fine on both Nexus One and Sony Xperia Play, both on Android 2.3. |
|
Thanks for checking - I was worried something wouldn't link. -[Unknown] |
We try to connect() to both, so should still be safe in environments where ipv6 is broken.
Let's hope no platform has issues with inet_ntop...
Hurray, no longer "part of the problem" for ipv4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some (slight) risk a client may be on a network where ipv6 doesn't properly work, but is available. This should try ipv4 even in that case, but I haven't tested it on such a network.
There's two reasons to go for ipv6:
The public IP is used to match devices in the same network. Now that report.ppsspp.org is ipv6, this is required for matching to work from an ipv6 client (e.g. a web browser, lua script, etc. for WebSocket based debugger interface #10909.)
We shouldn't be "part of the problem" for ipv4, as slight as our contribution to that is. Now version.json, homebrew downloads, etc. route via ipv6.
Should wait for post-1.6.1 or whatever. Tested this on Android/Windows/Mac, it both connects and listens properly there.
-[Unknown]