GPU: Force use of indexes on cull mode flip #11613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we flip in the index, it can't be pure in this case.
|
No Android Build For v1.7.1-219-gd1cf34cdf? |
|
It's here: https://buildbot.orphis.net/ppsspp/index.php?m=fulllist Seems like some sort of caching bug. May be related to the timeout running Windows tests, hopefully fixed in #11614. -[Unknown] |
|
It's totally fixed now TY :) Screenshot
|
This was referenced Dec 2, 2018
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we flip in the index, it can't be pure in this case. Fixes #11601 for real maybe.
We were lucky enough to hit the triangle just at MAX_DEFERRED_DRAW_CALLS, so it flushed right before. This meant that the clipped cull mode triangle draw was the only thing in the index generator. Tricky.
I also added
SetDrawType()for safety, but I'm not convinced the things it does are needed, except for non-triangles (which is already handled inPrimCompatible, so maybe the dirtying should be moved in there...)-[Unknown]