Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vk validation fixes, plus PowerVR swapchain hack #11747

Merged
merged 6 commits into from
Jan 26, 2019
Merged

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Jan 25, 2019

This makes us at least boot to a workable menu on PowerVR so you can switch out of Vulkan into OpenGL. However the emulator is still mostly broken, which I attribute to driver bugs at this point. It's also very slow, both in OpenGL and what works of Vulkan, but maybe Honor 7S is just a bad device (#11743).

It's possible that this could help #11457 too.

Copy link
Collaborator

@unknownbrackets unknownbrackets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like SDL needs updating.

I assume width/height still update on rotate for Android?

-[Unknown]

@hrydgard
Copy link
Owner Author

I'll fix up SDL. Android rotation works just fine.

@unknownbrackets
Copy link
Collaborator

Maybe it will even fix the Linux/SDL resizing issue somehow...

-[Unknown]

@hrydgard
Copy link
Owner Author

It doesn't. I have a separate branch with an attempt for that which I'll revive soon...

@hrydgard hrydgard merged commit 0758925 into master Jan 26, 2019
@hrydgard hrydgard deleted the vk-validation-fixes branch January 26, 2019 12:21
return false;
}
// Destructor will take care of the image.
return false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, shouldn't this be inside the ALLOCATE_FAILED if?

-[Unknown]

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops what happened here.. sloppy editing. I'll fix soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants