GE:Bugfix of some backend. #12538
GE:Bugfix of some backend. #12538
Conversation
Make UV of rectangle have a correct rotation.
|
Cool! Looks like a good catch, I'm going to take a closer look, probably tomorrow, and see why we didn't update the viewport correctly before in this case... |
GPU/GLES/DrawEngineGLES.cpp
Outdated
| @@ -562,6 +562,12 @@ void DrawEngineGLES::DoFlush() { | |||
| if (vertexCount > 0x10000 / 3) | |||
| vertexCount = 0x10000 / 3; | |||
| #endif | |||
| // Update viewport width & height before ST. | |||
There was a problem hiding this comment.
What if we just moved SoftwareTransform(...) below ApplyDrawState?
It used to be that way (in fact that's exactly why there's even a ApplyDrawStateLate, which needed to run after), but it was moved in f99fa02 which might've mainly been about hardware transform.
-[Unknown]
There was a problem hiding this comment.
Yes,it works,but it's a little complicated in vulkan,because vulkan applies draw state as pipeline key.
There was a problem hiding this comment.
Hm, right. Seems like we should ultimately refactor this, probably putting the viewport info on SoftwareTransformParams and maybe no longer having an ApplyDrawStateLate...
-[Unknown]
GPU/Directx9/ShaderManagerDX9.cpp
Outdated
| @@ -342,7 +342,7 @@ void ShaderManagerDX9::VSUpdateUniforms(u64 dirtyUniforms) { | |||
| flippedMatrix[12] = -flippedMatrix[12]; | |||
| } | |||
|
|
|||
| ConvertProjMatrixToD3D(flippedMatrix, invertedX, invertedY); | |||
| ConvertProjMatrixToD3D(flippedMatrix, invertedX, !invertedY); | |||
There was a problem hiding this comment.
Hm. If this is correct, I'd rather reverse the check inside the function rather than invert this value. This is the only call, and the argument inside and variable outside are both named invertedY.
I dislike the idea of them having opposite meanings - we should either inverse the check inside the func, or change one of the names, or reverse the way the variable is initially set here.
-[Unknown]
There was a problem hiding this comment.
Thinking about this more, is it a problem that this invert is in non-GL specific code?
ppsspp/GPU/Common/SoftwareTransformCommon.cpp
Lines 524 to 531 in 7790e61
(though I thought we used top down, or basically upside down, in GL buffers except the backbuffer...)
-[Unknown]
There was a problem hiding this comment.
Yeah, that looks really broken...
|
Switching to #12596, closing this now. |
This helps #12529.
List the graphics of all backend here:
Before:opengl & vulkan:brokenD3D9:has an incorrect offsetD3D11:normalAfter:Do normal thing as d3d11.