Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unification menu between Windows and Linux versions (need help) #12574

Closed
wants to merge 1 commit into from
Closed

Unification menu between Windows and Linux versions (need help) #12574

wants to merge 1 commit into from

Conversation

TotalCaesar659
Copy link
Contributor

I've tried to fix #10484. Some menu points are not implemented (cause I don't know how), some may be bugged, so I push it for checking.

@unknownbrackets
Copy link
Collaborator

Sorry for the lack of reply here. I think it'd be better to break this up and start with just the items you know what do and are implemented. That'll make it easier to review and easier to explain the ones that are still missing.

-[Unknown]

@TotalCaesar659
Copy link
Contributor Author

Do you want me to close this PR and start it partially over again?

@unknownbrackets
Copy link
Collaborator

I'm generally a fan of updating existing pull requests, but either way is fine. I think we should split up the commits to make it easier.

Some of these options I think are actually Windows specific or may require non-trivial work to implement for Qt. But there are other menu items we could update and get in real soon. I think splitting it up is the first step.

Some examples:

  • bVSync - this is actually forced on for Linux / Qt / etc. right now. It may be possible to disable but it's going to be more work than just the menus.
  • Open directory is intended to open a folder/directory which is an extracted ISO. It's usually used for rom hacking.

In general it looks like most of the menu items you added are working and look good, so it's hard for me to even tell which ones you're most concerned about.

-[Unknown]

@TotalCaesar659
Copy link
Contributor Author

OK, I think I'll better to make fresh PR with split commits and only those options that I'm sure, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unification menus on Windows and Linux versions
2 participants