Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software renderer clipper: Don't clip on the sides. #13294

Merged
merged 1 commit into from
Aug 18, 2020

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Aug 16, 2020

Fixes #13269. (#4845 and #7124 for the SW renderer).

@hrydgard hrydgard added this to the v1.11.0 milestone Aug 16, 2020
@unknownbrackets
Copy link
Collaborator

I wonder if the situation is more complex than this, because it seemed to do proper clipping when Z was out, even of the sides.

-[Unknown]

@unknownbrackets unknownbrackets merged commit 817dd33 into master Aug 18, 2020
@hrydgard hrydgard deleted the software-side-clip branch October 4, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Software renderer shouldn't clip triangles on the sides
2 participants