Add a cache for memory stick usage #14825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some games will loop over saves to check the size of each, and calculating the total usage is expensive. We don't need to recalculate each time.
This way if they switch away to delete files, it will have more free space.
|
Looks good, let's try it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #13847 - this will at least reduce how often we recalculate the size of SAVEDATA, by caching it between writes.
Flushes this cache on any write to the memory stick (not just savedata, for simplicity and durability), and also when resuming/focusing the app. This is to make sure external deletions work in a mostly sane way to reduce usage.
-[Unknown]