Cleanup some warnings from static analysis #16542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also missing virtual destructors, hidden non-overrides, etc.
We already have versions of these doing other conversions.
This makes what they do and which args to use clearer, if nothing else.
Cleaning up a lot of cases of uninitialized data, unchecked return values for failures, and similar.
unknownbrackets
added
the
Code Cleanup
|
Potentially I could rebase out "Global: Cleanup initialization/pointer checks." (9cfcbc4) and make it a separate PR, because I think it's where any real risk is. That said, I tried to be pretty careful with the changes... -[Unknown] |
|
Skimmed through it, all of it looks safe enough. Let's get it in. |
hrydgard
approved these changes
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the recent texture issue causing some memory corruption, I thought I'd run a pass of MSVC's analyzer.
Some of this is just cleaned up override/const specifiers and some variable initialization, but there's a delete after free, and some range things that are probably for the better.
It's also a net negative on lines of code, which is nice.
-[Unknown]