Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Force align verts to 4 on Apple devices #16816

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

unknownbrackets
Copy link
Collaborator

Quick change based on comments in #15149, although I will be surprised if this somehow affects the NANs we saw...

-[Unknown]

@unknownbrackets unknownbrackets added this to the v1.15.0 milestone Jan 18, 2023
@hrydgard
Copy link
Owner

Doesn't seem to change anything, unfortunately.

@anr2me
Copy link
Collaborator

anr2me commented Jan 18, 2023

Is this also includes unsupported vertex stride? https://github.com/cemu-project/Cemu/pull/445/files

When an unsupported vertex stride is given, replace with zero. Trying to set to any other value makes all textures corrupted, flicker and cover the whole screen. Also added output to log

Effects include many missing textures are now rendered visually correct. Any related missing textures may also be rendered but may have incorrect position and orientation.

@unknownbrackets
Copy link
Collaborator Author

This doesn't pass zero, which was changed in the newer linked PR (cemu-project/Cemu#534.) Even if it doesn't fix the M1 issue, it might make sense to merge it given Cemu presumably hit some sort of driver issue. It seems fairly cheap.

It would mostly matter in cases where games are using 8-bit verts and not using 8888/etc. It did seem like the GTA frame dump used an affected format, one way or another.

-[Unknown]

@hrydgard
Copy link
Owner

Whether this fixes anything or not, actually I think we should get this in. It can't possibly hurt.

@hrydgard hrydgard merged commit 03f64a0 into hrydgard:master Jan 20, 2023
@unknownbrackets unknownbrackets deleted the metal-align-verts branch January 20, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants