Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter: Optimize ReadVector/WriteVector by removing voffset lookups #18314

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Oct 5, 2023

Today's microoptimization. The V() macro does a table lookup, which is kinda unnecessary.

Drops these functions down the ranking of top functions by quite a bit in GTA, speedup at most 0.5% though. But enough of these small ones and they start adding up.

Not sure why GTA falls back to the interpreter for these so much though. I guess some "uneaten" prefix..

Drops these functions down the ranking of top functions by quite a bit in GTA,
speedup at most 0.5% though. But enough of these small ones and they
start adding up.

Not sure why GTA falls back to the interpreter for these so much though.
I guess some "uneaten" prefix..
@hrydgard hrydgard added this to the v1.17.0 milestone Oct 5, 2023
@hrydgard hrydgard merged commit 0cd02ab into master Oct 5, 2023
18 checks passed
@hrydgard hrydgard deleted the read-write-vector-opt branch October 5, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant