Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenXR - Projection matrix on Quest 3 fixed #18438

Merged
merged 2 commits into from
Nov 23, 2023
Merged

OpenXR - Projection matrix on Quest 3 fixed #18438

merged 2 commits into from
Nov 23, 2023

Conversation

lvonasek
Copy link
Contributor

This fixes many games on Meta Quest 3. For some reason the previous calculation of projection matrix didn't work on Quest 3. This is a simplified version which is not compatible with FOV feature. I think it is good to remove the FOV feature, it worked only if watching forwards anyway. It would be good to have it on 2D screens but for VR it is bad.

@sum2012
Copy link
Collaborator

sum2012 commented Nov 23, 2023

Please also delete "Field of view scale" and "% of native FoV" phase in \assets\lang\ *.ini

Copy link
Owner

@hrydgard hrydgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seconding sum2012's suggestion, otherwise seems fine.

Thank you for taking care of this.

@hrydgard hrydgard added the VR OpenXR VR support label Nov 23, 2023
@hrydgard hrydgard added this to the v1.17.0 milestone Nov 23, 2023
@lvonasek
Copy link
Contributor Author

I cleaned the texts as suggested. VR build upoaded here:
https://drive.google.com/drive/folders/1609uufJhLZlc0GrcXxis45312erzHZMb?usp=drive_link

Feel free to post it on your Discord.

@hrydgard hrydgard merged commit d6324d1 into hrydgard:master Nov 23, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VR OpenXR VR support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants