Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tokimeki Flashing to Black Screen issue #18820

Closed
wants to merge 1 commit into from

Conversation

sum2012
Copy link
Collaborator

@sum2012 sum2012 commented Feb 3, 2024

Fix #18811

In the opening the game,
fb_stride = 256, z_stride = 512

In the "arm" screen ,
fb_stride = 512, z_stride = 512

@sum2012 sum2012 added the GE emulation Backend-independent GPU issues label Feb 3, 2024
@hrydgard
Copy link
Owner

hrydgard commented Feb 3, 2024

Hm, isn't the check backwards? it's in the arm scene where they are equal that we need the framebuffer merging, no?

Anyway, interesting - i'm gonna take another quick look tomorrow

@sum2012
Copy link
Collaborator Author

sum2012 commented Feb 4, 2024

It is still fix the tokimeki bug with the weird bottom part of the screen.

@sum2012
Copy link
Collaborator Author

sum2012 commented Feb 4, 2024

3

@hrydgard
Copy link
Owner

hrydgard commented Feb 4, 2024

Thanks for testing this. Found a cleaner fix, see #18822. Closing.

@hrydgard hrydgard closed this Feb 4, 2024
@sum2012 sum2012 deleted the Tokimeki-fix branch February 4, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GE emulation Backend-independent GPU issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flashing to Black Screen in Tokimeki Memorial 4
2 participants