Fix to VFPU register allocation. Fixes #7174 #7217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetFreeXRegs(_,_,true) invalidates registers it can see on spill, but it can't see all the registers in the array due to how we call it so we have to invalidate the rest ourselves. Not doing so can get it to use the same register twice.
|
Oh, nice one, thanks! If it's just a few instructions, the minimal required to reproduce the bug, I think it's fine to add the test as well.. |
hrydgard
added a commit
that referenced
this pull request
Dec 23, 2014
Fix to VFPU register allocation. Fixes #7174
|
Oops, thanks. Yeah, more tests for regcache bugs are good. Will help arm and armv8 as well. -[Unknown] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetFreeXRegs(,,true) invalidates registers it can see on spill,
but it can't see all the registers in the array due to how we call it
so we have to invalidate the rest ourselves. Not doing so can get it
to use the same register twice.
I also have a relevant auto-test if there's any interest. It is transcribed directly from a game though.