Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cull out-of-bounds triangles that were not clipped #9527

Closed
wants to merge 3 commits into from
Closed

Cull out-of-bounds triangles that were not clipped #9527

wants to merge 3 commits into from

Commits on Aug 5, 2018

  1. Experimental way to cull out-of-bounds triangles. Helps #5001, at lea… 

    …st for Toca.

Really not sure how big the guard band should be, and the right way to
do this would be to use a geometry shader instead of killing triangles
by setting w = NaN, which I'm not sure will do sane things on all
hardware. Unfortunately geometry shaders are not available everywhere.

Assumes the viewport is centered in the 4096x4096 rectangle to save a
uniform.

Ignores the bottom for now, can't figure out TOCA :(
    @hrydgard
    hrydgard committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    1db0cf9 View commit details
    Browse the repository at this point in the history

  2. Testing a workaround on D3D11/9 only for now: since we don't know how… 

    … the clipper works when Z is out of range, let's only cull when Z is in range.
    @hrydgard
    hrydgard committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    2013eb3 View commit details
    Browse the repository at this point in the history

  3. Oops. Didn't affect compilation though since sHADERLOG wasn't defined… 

    …. Rebase away this next time.
    @hrydgard
    hrydgard committed Aug 5, 2018
    Configuration menu
    Copy the full SHA
    02aef58 View commit details
    Browse the repository at this point in the history