Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:修复创建查询字段sql失败时也会添加逗号分割问题 #54

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

goten7
Copy link
Contributor

@goten7 goten7 commented Sep 27, 2023

No description provided.

Copy link
Member

@zhou-hao zhou-hao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

尝试在SelectColumnFragmentBuilderTest中复现此问题,并测试通过。

sql = this.createFragments(parameter, column);
if (sql != null) {
PrepareSqlFragments sqlNext = this.createFragments(parameter, column);
if (sqlNext != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该还要判断 isNotEmpty

@zhou-hao zhou-hao merged commit ed4e4ad into hs-web:master Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants