Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 添加根据列全名解析表别名方法 #71

Merged
merged 3 commits into from
May 17, 2024

Conversation

goten7
Copy link
Contributor

@goten7 goten7 commented May 14, 2024

No description provided.

char firstChar = name.charAt(0);

if (firstChar == '`' || firstChar == '"' || firstChar == '[' ||
name.startsWith(dialect.getQuoteStart())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dialect.getQuoteStart() 是多个字符时,截取可能不对。

if (firstChar == '`' || firstChar == '"' || firstChar == '[' ||
name.startsWith(dialect.getQuoteStart())) {

return new String(name.toCharArray(), 1, name.length() - 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

直接substring?

@goten7 goten7 requested a review from zhou-hao May 15, 2024 07:54

return new String(name.toCharArray(), 1, name.length() - 2);
if (name.startsWith(dialect.getQuoteStart())) {
return name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用substring截取前后。

@zhou-hao zhou-hao merged commit d77de93 into hs-web:master May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants