Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use js_app.html as the landing page for Chrome-Devtools #3

Merged
merged 2 commits into from
Aug 1, 2019
Merged

Use js_app.html as the landing page for Chrome-Devtools #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
152b4d9
Use js_app.html as the landing page for Chrome-Devtools
GauthamBanasandra Aug 10, 2018
273021f
Make build compatible
GauthamBanasandra Aug 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,26 @@ CMAKE_MINIMUM_REQUIRED (VERSION 2.8)

PROJECT (v8inspector)

INCLUDE (FindV8.cmake)
INCLUDE (FindICU.cmake)
#INCLUDE (FindV8.cmake)
#INCLUDE (FindICU.cmake)
INCLUDE (FindLZ.cmake)
INCLUDE (FindLIBUV.cmake)
#INCLUDE (FindLIBUV.cmake)
INCLUDE (FindOPENSSL.cmake)

INCLUDE_DIRECTORIES( ${ICU_INCLUDE_DIR}
${LIBUV_INCLUDE_DIR}
SET(V8_INCLUDE_DIR /Users/gautham/.cbdepscache/include)
SET(V8_LIBRARIES
/Users/gautham/.cbdepscache/lib/libv8.dylib
/Users/gautham/.cbdepscache/lib/libv8_libplatform.dylib
/Users/gautham/.cbdepscache/lib/libv8_libbase.dylib)

SET(ICU_LIBRARIES
/Users/gautham/.cbdepscache/lib/libicui18n.dylib
/Users/gautham/.cbdepscache/lib/libicuuc.dylib)

SET(LIBUV_LIBRARIES
/Users/gautham/.cbdepscache/lib/libuv.dylib)

INCLUDE_DIRECTORIES(
${V8_INCLUDE_DIR}
${OPENSSL_INCLUDE_DIR}
${V8_INCLUDE_DIR}/include
Expand Down
4 changes: 2 additions & 2 deletions inspector_socket_server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ void PrintDebuggerReadyMessage(const std::string& host,
for (const std::string& id : ids) {
std::string frontend_url;
frontend_url = "chrome-devtools://devtools/bundled";
frontend_url += "/inspector.html?experiments=true&v8only=true&ws=";
frontend_url += "/js_app.html?experiments=true&v8only=true&ws=";
frontend_url += FormatWsAddress(host, port, id, false);
fprintf(out, "%s\n", frontend_url.c_str());
fprintf(stderr, "Debugger starting on %s\n", frontend_url.c_str());
Expand Down Expand Up @@ -402,7 +402,7 @@ void InspectorSocketServer::SendListResponse(InspectorSocket* socket) {
GetSocketHost(&socket->tcp, &host);
std::ostringstream frontend_url;
frontend_url << "chrome-devtools://devtools/bundled";
frontend_url << "/inspector.html?experiments=true&v8only=true&ws=";
frontend_url << "/js_app.html?experiments=true&v8only=true&ws=";
frontend_url << FormatWsAddress(host, port, id, false);
target_map["devtoolsFrontendUrl"] += frontend_url.str();
target_map["webSocketDebuggerUrl"] =
Expand Down