Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scale] bump d3-scale dep for scaleSymlog #477

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Conversation

hshoff
Copy link
Member

@hshoff hshoff commented Jul 9, 2019

Counterpart to #470 which makes sure the correct d3-scale version is installed to support the addition of scaleSymlog.

💥 Breaking changes

🚀 Enhancements

  • [scale] bump d3-scale dep to ^2.2.2 for scaleSymlog

Sidenote: Since d3-scale added convenience constructors (scale(domain, range)) we may deprecate @vx/scale in favor of d3-scale in the future. Currently, @vx/scale only adds two additional behaviors around d3-scale: Convenience constructors (as named args: scale({ domain, range })) and a .type property on scale instances. These benefits may not be worth the cost of maintaining the wrapping functions. I always thought i would add a way to make scales immutable, but it may not be worth it anymore.

@hshoff hshoff added this to the v0.0.190 milestone Jul 9, 2019
@hshoff hshoff merged commit cf1bbb9 into master Jul 9, 2019
@hshoff hshoff deleted the harry-scale-bump branch July 9, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant