fix: change default SkipStrategy to NeverSkip (#95)

hstreamdb · Dec 11, 2023 · 504f2a3 · 504f2a3
1 parent 8daffb1
commit 504f2a3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/java-toolkit/lib/src/main/java/io/hstream/io/impl/SinkSkipStrategyImpl.java b/java-toolkit/lib/src/main/java/io/hstream/io/impl/SinkSkipStrategyImpl.java
@@ -16,7 +16,7 @@
 @Slf4j
 public class SinkSkipStrategyImpl implements SinkSkipStrategy {
     // skip
-    int skipCount = -1;
+    int skipCount = 0;
     AtomicInteger skipped = new AtomicInteger(0);
     HStreamClient client;
     ErrorRecorder errorRecorder;

diff --git a/java-toolkit/lib/src/main/java/io/hstream/io/impl/spec/ErrorSpec.java b/java-toolkit/lib/src/main/java/io/hstream/io/impl/spec/ErrorSpec.java
@@ -37,7 +37,7 @@ static public class SkipStrategy implements SpecProperty {
         String uiShowName = "Skip Strategy";
         String description = "skip strategy if records is unwritable";
         String type = "string";
-        JsonNode defaultValue = new TextNode("SkipAll");
+        JsonNode defaultValue = new TextNode("NeverSkip");
         List<JsonNode> enumValues = List.of(new TextNode(SkipStrategyEnum.SkipAll.name()),
                 new TextNode(SkipStrategyEnum.NeverSkip.name()),
                 new TextNode(SkipStrategyEnum.SkipSome.name()));