Fix 3rdparty detector bugs #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 1, 2020 20:15
1. NAB benchmark contained duplicate timestamps which caused length to not match up with imported results, throwing errors 2. Threshold values were read in as strings instead of floats, throwing errors Signed-off-by: Patrick Menninger <patrick.menninger@viasat.com>
Duplicate fixes from previous commit broke the default detectors, so I made them optional Signed-off-by: Patrick Menninger <patrick.menninger@viasat.com>
|
Hi, Sorry it took a year for anyone to respond to your PR. I didn't merge the stuff about duplicate records BC I've never encountered that bug. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when evaluating my own detector using this process that there were two bugs that got in the way:
--removeDuplicateLabelsflag. The default behavior remains unchanged.sweeper.py, which does not affect the default behavior because the anomaly scores from the default detectors are correctly read in as floats anyway.