Use bytes on pickle SpatialPooler and TemporalMemory

[Lupino]

Fixed UnicodeDecodeError, when pickle SpatialPooler or TemporalMemory

#160

[breznak]

Thanks @Lupino 👍
this looks good!
Can you please add/enable the tests which use pickle serialization to show this is working?

[ctrl-z-9000-times]

Hi Lupino,

I think I know why you code does not work. It looks like a problem with pybind11 and python2. I found this thread discussing it: pybind/pybind11#271

Try replacing import pickle with:

try:
    import cPickle as pickle # For python 2
except ImportError:
    import pickle # For python 3

[Lupino]

Hi Lupino,

I think I know why you code does not work. It looks like a problem with pybind11 and python2. I found this thread discussing it: pybind/pybind11#271

Try replacing import pickle with:

try:
    import cPickle as pickle # For python 2
except ImportError:
    import pickle # For python 3

I changed but also failed

[Lupino]

https://github.com/htm-community/nupic.cpp/blob/master/bindings/py/tests/nupic_random_test.py#L76

I found pickle is mark failed on this file.

[ctrl-z-9000-times]

I think that the next best thing would be to detect which version of python is running and skip the unit tests if it's python 2. Then at least we can have this working and tested for python3.

The pytest docs have some examples of how to do this:
https://docs.pytest.org/en/latest/skipping.html?highlight=skipping#id1

[breznak]

This ended up a really nice PR! Thank you @Lupino 👍