Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(idclassaddisabled): typo in default export name #728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nschonni
Copy link
Contributor

Short description of what this resolves:
The default export name was misspelled.
This may be a breaking change

Proposed changes:

@github-actions github-actions bot added the core Relates to HTMLHint's core APIs and features label Nov 23, 2021
@thedaviddias
Copy link
Member

Short description of what this resolves: The default export name was misspelled. This may be a breaking change

Proposed changes:

If you don't mind, I'm holding off a little as I would like to release a major version with some changes first.

@thedaviddias thedaviddias added the keep-unstale The issue will not be marked as stale by the stale-bot label Nov 24, 2021
@nschonni
Copy link
Contributor Author

No problem, this isn't a big issue

BREAKING CHANGE: The default export name is changed
@codecov
Copy link

codecov bot commented Nov 27, 2021

Codecov Report

Merging #728 (de1a6f9) into master (432d4eb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #728   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files           1        1           
  Lines         917      917           
  Branches      191      191           
=======================================
  Hits          904      904           
  Misses         13       13           
Impacted Files Coverage Δ
dist/htmlhint.js 98.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432d4eb...de1a6f9. Read the comment docs.

@coliff
Copy link
Member

coliff commented Sep 6, 2022

Can this be merged ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Relates to HTMLHint's core APIs and features keep-unstale The issue will not be marked as stale by the stale-bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants