Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop supertrait requirements on SessionStore #51

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

jbr
Copy link
Member

@jbr jbr commented Dec 13, 2022

with this change, frameworks can specify if they need any or all of these constraints, like SessionStore + Send + Sync + 'static

closes #33

with this change, frameworks can specify if they need any or all of these constraints, like `SessionStore + Send + Sync + 'static`
@jbr
Copy link
Member Author

jbr commented Dec 13, 2022

frameworks that need to retain the Send + Sync + 'static bounds can do something like this: https://github.com/trillium-rs/trillium/pull/239/files#diff-c71367ad5c2eaf26b59927686beb0b822739121476995ddf39e7d6dd28ef05a8R38-R39

Copy link

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and I'd also like to have this

@jbr jbr merged commit 1c686d8 into main Feb 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the drop-sessionstore-supertraits branch February 17, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Clone trait requirement from SessionStore
2 participants