Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Client and Server traits #218

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Remove Client and Server traits #218

merged 1 commit into from
Aug 12, 2020

Conversation

yoshuawuyts
Copy link
Member

Removes the experimental Client and Server traits. We won't be using Server for Tide, and the chance is slim we'll use Client for Surf. So it may be best to remove them from the project. Thanks!

@goto-bus-stop goto-bus-stop changed the base branch from master to main August 9, 2020 12:58
Copy link
Member

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to merge, but this is semver-major so we should discuss

@jbr jbr added the semver-major This change requires a semver major change label Aug 10, 2020
@jbr
Copy link
Member

jbr commented Aug 12, 2020

@Fishrock123 pointed out that this is not semver-major because it was unstable, so merging. My mistake!

@jbr jbr removed the semver-major This change requires a semver major change label Aug 12, 2020
@jbr jbr merged commit ccd7ecb into main Aug 12, 2020
@yoshuawuyts yoshuawuyts deleted the remove-client-server branch August 14, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants