Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: ignore rc_buffer clippy warning #242

Merged
merged 1 commit into from
Sep 27, 2020

Commits on Sep 26, 2020

  1. client: ignore rc_buffer clippy warning

    This new lint popped up overnight, see
    rust-lang/rust-clippy#6044
    
    The problem is that we do indeed want this structure.
    - The outer Arc allows us to clone in .send() without cloning the array.
    - The Vec allows us to add middleware at runtime.
    - The inner Arc-s allow us to implement Clone without sharing the vector with the parent.
    - We don't use a Mutex around the Vec here because adding a middleware during execution should be an error.
    Fishrock123 committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    a30be46 View commit details
    Browse the repository at this point in the history