Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tide-log #222

Merged
merged 4 commits into from
May 21, 2019
Merged

add tide-log #222

merged 4 commits into from
May 21, 2019

Conversation

prasannavl
Copy link
Contributor

@prasannavl prasannavl commented May 15, 2019 •
edited
Loading

Description

Depends on #220

Motivation and Context

How Has This Been Tested?

Running on several different environment successfully, and merely hands off to log crate.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prasannavl prasannavl mentioned this pull request May 15, 2019
Open
fairingrey
fairingrey reviewed May 16, 2019
View reviewed changes
tide-log/Cargo.toml Outdated Show resolved Hide resolved
fairingrey
fairingrey reviewed May 16, 2019
View reviewed changes
tide-log/Cargo.toml Outdated Show resolved Hide resolved
@prasannavl
Copy link
Contributor Author

Also rebased over #220 while tweaking the manifest.

This was referenced May 17, 2019
Closed
Open
fairingrey
fairingrey reviewed May 17, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@yoshuawuyts
Copy link
Member

#220 was merged, this should be ready for a rebase!

fairingrey
fairingrey reviewed May 19, 2019
View reviewed changes
Cargo.toml Show resolved Hide resolved
This was referenced May 20, 2019
Merged
Closed
yoshuawuyts
yoshuawuyts approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty great! -- I think we should merge this!

tide-log/src/lib.rs Outdated Show resolved Hide resolved
fairingrey
fairingrey suggested changes May 21, 2019
View reviewed changes
tide-log/src/lib.rs Outdated Show resolved Hide resolved
@fairingrey fairingrey merged commit 4df808d into http-rs:master May 21, 2019
@yoshuawuyts yoshuawuyts mentioned this pull request Oct 31, 2019
Closed
@drewish drewish mentioned this pull request Mar 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nemo157 Nemo157 Nemo157 left review comments

@fairingrey fairingrey fairingrey approved these changes

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slog-async Error Logging middleware should not be always-applied and better move to separate crate
4 participants
@prasannavl @yoshuawuyts @Nemo157 @fairingrey