Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core revamp part 2 #252

Merged
merged 8 commits into from
May 21, 2019
Merged

Conversation

prasannavl
Copy link
Contributor

@prasannavl prasannavl commented May 21, 2019

Description

  • Depend on tide-core for tide-log instead of full tide
  • DefaultHeaders to new crate tide-headers
    • Add trace
    • Remove inline attr that's counter intuitive.
  • RootLogger -> RequestLogger in new crate tide-slog
    • Minor refactors
    • Add with_logger constructor
    • Make behaviour consistent with tide-log
  • tide-log
    • Add with_target constructor to configure log target
    • Make default target as requests
  • [BREAKING] Make RequestLogger from tide be exposed from tide::middleware
  • [BREAKING] Remove tide-slog based logger from tide::middleware.

Other

  • Add examples: hello_envlog, hello_logrs
  • Add tide as dev-dependency to all crates, since they'll all require documentation at some point
  • Minor additional documentation throughout touched surface

Additional PRs left:

TODO - Core revamp - Part 3

  • Extract form.rs into tide-forms
  • Extract querystring.rs into tide-querystring

TODO - Core revamp - Part 4

  • Move non essentials from tide-core into tide

Motivation and Context

#162

How Has This Been Tested?

All tests passed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@prasannavl prasannavl marked this pull request as ready for review May 21, 2019 11:44
Copy link
Contributor

@Nemo157 Nemo157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual revamp LGTM, probably my comment on tide-slog would be better as a separate issue.

Copy link
Member

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

add newline before EOF
tide-headers/Cargo.toml Outdated Show resolved Hide resolved
tide-log/Cargo.toml Outdated Show resolved Hide resolved
tide-slog/Cargo.toml Outdated Show resolved Hide resolved
@fairingrey
Copy link
Contributor

LGTM! Will merge after checks finish.

@fairingrey fairingrey merged commit 82e990c into http-rs:master May 21, 2019
@prasannavl
Copy link
Contributor Author

Thanks @fairingrey for fixing up the names.

Part 3 sitting in here, though not ready yet: https://github.com/rustasync/tide/compare/master...prasannavl:core_revamp_3?expand=1

(Have the macro bit to resolve. Should be able to make some time a little later tonight)

@prasannavl prasannavl deleted the core_revamp_part_2 branch May 21, 2019 16:10
This was referenced May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants