-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core revamp part 2 #252
Core revamp part 2 #252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual revamp LGTM, probably my comment on tide-slog
would be better as a separate issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
add newline before EOF
LGTM! Will merge after checks finish. |
Thanks @fairingrey for fixing up the names. Part 3 sitting in here, though not ready yet: https://github.com/rustasync/tide/compare/master...prasannavl:core_revamp_3?expand=1 (Have the macro bit to resolve. Should be able to make some time a little later tonight) |
Description
tide-core
fortide-log
instead of fulltide
DefaultHeaders
to new cratetide-headers
inline
attr that's counter intuitive.RootLogger
->RequestLogger
in new cratetide-slog
with_logger
constructortide-log
tide-log
with_target
constructor to configure logtarget
target
asrequests
RequestLogger
from tide be exposed fromtide::middleware
tide-slog
based logger fromtide::middleware
.Other
hello_envlog
,hello_logrs
tide
asdev-dependency
to all crates, since they'll all require documentation at some pointAdditional PRs left:
TODO - Core revamp - Part 3
form.rs
intotide-forms
querystring.rs
intotide-querystring
TODO - Core revamp - Part 4
tide-core
intotide
Motivation and Context
#162
How Has This Been Tested?
All tests passed
Types of changes
Checklist: