Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to define custom data types #235

Merged
merged 7 commits into from
May 29, 2023

Conversation

MrKirat
Copy link
Contributor

@MrKirat MrKirat commented May 27, 2023

Hi!

Currently, the library supports only a limited number of types - array, hash, big_decimal, integer, float, string, boolean.
I have a need to save custom types into a DB, so I decided to try to add the functionality that will allow me to do that. During implementation, I also tried to refactor a little bit of other code in order to make it more readable.

So here is what I've done so far:

Take note, that I was trying to keep us much backward compatibility as I can. At this moment it seems like all tests are being passed successfully.

Maintainers (@codez @berkos @huacnlee), could you please let me know whether it makes sense?

If yes, I will prepare the PR for the merge. If not - you are free to close it :)

@MrKirat MrKirat changed the title Refactoring Add ability to define custom data types May 27, 2023
@huacnlee
Copy link
Owner

Too many changes, please do not change code style.

@MrKirat MrKirat force-pushed the kirat/add-ability-to-add-custom-types branch from ff0c573 to 93d478a Compare May 28, 2023 12:23
@MrKirat
Copy link
Contributor Author

MrKirat commented May 28, 2023

@huacnlee I've pushed new changes only focused on the ability to add custom data types. Could you please check the changes again?

@huacnlee
Copy link
Owner

Great work!

@huacnlee huacnlee merged commit bbb7a67 into huacnlee:main May 29, 2023
huacnlee added a commit that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants