refs #14: implement FindFirstElementGreaterOrEqualToKey #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Iac0725a351c0efb24319a95e39d4fbf5e329d6a3
huandu
requested changes
Sep 23, 2021
skiplist.go
Outdated
| // If there is no such element, returns nil. | ||
| // | ||
| // The complexity is O(log(N)). | ||
| func (list *SkipList) FindFirstElementGreaterOrEqualToKey(key interface{}) (elem *Element) { |
There was a problem hiding this comment.
这个接口的名字太长了，希望改成 Find，注释里写好这个函数的功能即可，不用那么长的名字。
There was a problem hiding this comment.
另外建议提供两个公开方法：
// 相当于调用 list.FindNext(nil, key)
func (list *SkipList) Find(key interface{}) (elem *Element)
// 从 elem 开始查找下一个符合要求的 key，elem 自身不包含。
func (list *SkipList) FindNext(elem *Element, key interface{}) (elem *Element)另外提供一个私有方法，将计算好的 score 放进去，减少 calcScore 调用。
func (list *SkipList) findNext(start *Element, score float64, key interface{}) (elem *Element)
skiplist.go
Outdated
| if list.length == 0 { | ||
| firstElem := list.FindFirstElementGreaterOrEqualToKey(key) | ||
| if firstElem == nil { | ||
| elem = nil |
skiplist.go
Outdated
|
|
||
| if score < list.Front().score || score > list.Back().score { | ||
| if list.compare(score, key, firstElem) != 0 { | ||
| elem = nil |
skiplist.go
Outdated
| @@ -243,41 +243,19 @@ func (list *SkipList) Set(key, value interface{}) (elem *Element) { | |||
| // | |||
| // The complexity is O(log(N)). | |||
| func (list *SkipList) Get(key interface{}) (elem *Element) { | |||
| if list.length == 0 { | |||
| firstElem := list.FindFirstElementGreaterOrEqualToKey(key) | |||
There was a problem hiding this comment.
由于 Find 函数里面调用 calcScore 计算了 score，下面的代码再次计算了一次，有些浪费，建议写一个内部函数 findNext(start *Element, score float64, key interface{}) (elem *Element)，传入计算好的 score，省去额外的 calcScore。
Change-Id: Id2b9a018b2700133fbd5186f60a03c45fd18d80d
|
@huandu hello 感谢 comments，已调整代码 |
|
没有问题了，已经合并。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.