Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulation #79

Merged
merged 9 commits into from
Oct 6, 2023
Merged

Encapsulation #79

merged 9 commits into from
Oct 6, 2023

Conversation

abhinna1
Copy link
Contributor

@abhinna1 abhinna1 commented Oct 3, 2023

Concept of encapsulation in OOP introduces for making class attributes public and private.

Copy link
Owner

@huangsam huangsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial round of feedback

ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #79 (93d317c) into master (8731e3b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        30    +1     
  Lines          919       966   +47     
  Branches        94        97    +3     
=========================================
+ Hits           919       966   +47     
Files Coverage Δ
ultimatepython/classes/encapsulation.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@abhinna1
Copy link
Contributor Author

abhinna1 commented Oct 3, 2023

@huangsam I've made new changes as per your review. Can you please review the code again? Thank you!

Copy link
Owner

@huangsam huangsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second round of feedback

ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
@abhinna1
Copy link
Contributor Author

abhinna1 commented Oct 4, 2023

@huangsam I've made new updates as per your suggestions. I've made sure to reply to your comments at places where I might've gotten a little confused. Thank you!

Copy link
Owner

@huangsam huangsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is getting better! Also, note that there are a few lines that are not covered by the main function. Can we make sure we get 100% code coverage?

ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
ultimatepython/classes/encapsulation.py Outdated Show resolved Hide resolved
@abhinna1
Copy link
Contributor Author

abhinna1 commented Oct 5, 2023

@huangsam I've made the changes. Hope they're good for merging now. 😃

@huangsam
Copy link
Owner

huangsam commented Oct 6, 2023

@abhinna1 the code looks good! Now it's time to get it into the README files at the top-level. Can you please add this module to all the README files? If not, at least the first README.md file will do

@abhinna1
Copy link
Contributor Author

abhinna1 commented Oct 6, 2023

@huangsam I've updated the Markdown 😄

@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@huangsam
Copy link
Owner

huangsam commented Oct 6, 2023

Awesome @abhinna1 thanks for your contribution 🎉

@huangsam huangsam merged commit 121366f into huangsam:master Oct 6, 2023
5 checks passed
@abhinna1
Copy link
Contributor Author

It's my pleasure @huangsam 😄 ! Looking forward to more contributions in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants