-
-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encapsulation #79
Encapsulation #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial round of feedback
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 30 +1
Lines 919 966 +47
Branches 94 97 +3
=========================================
+ Hits 919 966 +47
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@huangsam I've made new changes as per your review. Can you please review the code again? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second round of feedback
@huangsam I've made new updates as per your suggestions. I've made sure to reply to your comments at places where I might've gotten a little confused. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is getting better! Also, note that there are a few lines that are not covered by the main
function. Can we make sure we get 100% code coverage?
@huangsam I've made the changes. Hope they're good for merging now. 😃 |
@abhinna1 the code looks good! Now it's time to get it into the README files at the top-level. Can you please add this module to all the README files? If not, at least the first README.md file will do |
@huangsam I've updated the Markdown 😄 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Awesome @abhinna1 thanks for your contribution 🎉 |
It's my pleasure @huangsam 😄 ! Looking forward to more contributions in the future! |
Concept of encapsulation in OOP introduces for making class attributes public and private.