Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WAF] add Data Masking rule resource #1295

Merged

Conversation

chengxiangdong
Copy link
Collaborator

@chengxiangdong chengxiangdong commented Jul 19, 2021

What this PR does / why we need it:

Support the management of the data masking rules of the policy.

  • Create rules for the specified policy.
  • Update the rules.
  • Delete the existing rule.
  • Support for importing existing rules from HUAWEI CLOUD to Terraform.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #1280

Special notes for your reviewer:

  • The field supports 4 parameters: header, params, form and cookie, which are not fully supplemented in the API documentation.

Release note:

1. Added resource('huaweicloud_waf_rule_data_masking') for manging the rules of policy. 
2. For complete use, it needs to be released together with WAF policy management.  And WAF policy management has been merged into master.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud/services/acceptance/waf' TESTARGS='-run TestAccWafRuleDataMasking_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/waf -v -run TestAccWafRuleDataMasking_basic -timeout 360m -parallel 4
=== RUN   TestAccWafRuleDataMasking_basic
=== PAUSE TestAccWafRuleDataMasking_basic
=== CONT  TestAccWafRuleDataMasking_basic
--- PASS: TestAccWafRuleDataMasking_basic (33.45s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/waf       33.540s

@chengxiangdong chengxiangdong changed the title Add WAF policy rule management supports #1280 Add WAF policy rule management supports Jul 20, 2021
@chengxiangdong chengxiangdong force-pushed the feat_waf_data_masking_rules branch 3 times, most recently from 89189c5 to 18f2658 Compare July 20, 2021 02:06
@chengxiangdong chengxiangdong changed the title Add WAF policy rule management supports [WAF] add Data Masking rules resource Jul 20, 2021
@chengxiangdong chengxiangdong changed the title [WAF] add Data Masking rules resource [WAF] add Data Masking rule resource Jul 20, 2021
@ShiChangkuo ShiChangkuo merged commit 707c6ab into huaweicloud:master Jul 21, 2021
@chengxiangdong chengxiangdong deleted the feat_waf_data_masking_rules branch July 23, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WAF policy rule management supports
2 participants