New APIG throttling policy resource supported #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending sdk supports throttling policy. |
| return fmtp.Errorf("Error saving special user throttles to state: %s", err) | ||
| } | ||
| apps := make([]map[string]interface{}, len(specThrottles)) | ||
| for i, throttle := range specThrottles { |
There was a problem hiding this comment.
It is better to construct users and apps in one loop.
There was a problem hiding this comment.
thx, that's easy to understand.
- support base type and share type - support four kinds of call limit - support special throttling policies management
- use more readable code - refactor the policies structure of attribute parameters
ShiChangkuo
reviewed
Jul 31, 2021
| This parameter applies with each of the API call limits: `max_api_requests`, `max_app_requests`, `max_ip_requests` | ||
| and `max_user_requests`. | ||
|
|
||
| * `max_api_requests` - (Required, Int) Specifies the maximum number of times an API can be accessed within a specified |
There was a problem hiding this comment.
please put max_api_requests, max_app_requests, max_ip_requests and max_user_requests together.
| return nil | ||
| } | ||
|
|
||
| func resourceApigThrottlingPolicyV2Create(d *schema.ResourceData, meta interface{}) error { |
There was a problem hiding this comment.
Please add some blank lines to make it easier to read.
- adjust the locations of all api limit call in document - add some blank lines and annotations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The throttling policy controls the number of times APIs can be called by a user, an app, or an IP address during a specific period to protect backend services.
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)reference: #1249
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed