Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dds): support primary standby switch #5768

Merged
merged 1 commit into from
Oct 29, 2024
Merged

feat(dds): support primary standby switch #5768

merged 1 commit into from
Oct 29, 2024

Conversation

saf3dfsa
Copy link
Contributor

@saf3dfsa saf3dfsa commented Oct 26, 2024 •
edited
Loading

What this PR does / why we need it:
support primary standby switch

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/dds" TESTARGS="-run TestAccDDSPrimaryStandbySwitch_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dds -v -run TestAccDDSPrimaryStandbySwitch_ -timeout 360m -parallel 4
=== RUN   TestAccDDSPrimaryStandbySwitch_basic
=== PAUSE TestAccDDSPrimaryStandbySwitch_basic
=== RUN   TestAccDDSPrimaryStandbySwitch_node
=== PAUSE TestAccDDSPrimaryStandbySwitch_node
=== CONT  TestAccDDSPrimaryStandbySwitch_node
=== CONT  TestAccDDSPrimaryStandbySwitch_basic
--- PASS: TestAccDDSPrimaryStandbySwitch_basic (794.44s)
--- PASS: TestAccDDSPrimaryStandbySwitch_node (803.02s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dds       803.074s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@saf3dfsa saf3dfsa force-pushed the feat(dds)_support_primary_standby_switch branch 2 times, most recently from 205644e to e7fab91 Compare October 28, 2024 01:41
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Oct 28, 2024
@saf3dfsa saf3dfsa force-pushed the feat(dds)_support_primary_standby_switch branch from e7fab91 to 332f05e Compare October 29, 2024 08:57
@github-ci-robot github-ci-robot removed the LGTM /lgtm label Oct 29, 2024
@github-actions github-actions bot added size/L and removed size/M labels Oct 29, 2024
@houpeng80
Copy link
Collaborator

/lgtm
/approve

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 29, 2024
github-ci-robot
github-ci-robot approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @houpeng80

/lgtm
/approve

@github-ci-robot github-ci-robot merged commit b23ebd2 into huaweicloud:master Oct 29, 2024
14 checks passed
@saf3dfsa saf3dfsa deleted the feat(dds)_support_primary_standby_switch branch November 14, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houpeng80 houpeng80 houpeng80 left review comments

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saf3dfsa @Jason-Zhang9309 @houpeng80 @github-ci-robot