Be a lot more flexible as for GHMemberChanges values #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, things are not consistent between added and edited. added provide a permission of some sort and a role name (sometimes...) edited only provides permission and it's not exactly the same ones For now, I think we need to return strings to avoid issues until GitHub adjusts the API.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1821 +/- ##
============================================
- Coverage 80.66% 80.64% -0.03%
- Complexity 2342 2354 +12
============================================
Files 220 223 +3
Lines 7082 7185 +103
Branches 379 395 +16
============================================
+ Hits 5713 5794 +81
- Misses 1132 1145 +13
- Partials 237 246 +9 ☔ View full report in Codecov by Sentry. |
|
I think the bridge methods are causing the coverage issue. I added some tests in the bridge methods test. |
bitwiseman
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, things are not consistent between added and edited for the
memberevent.added provide a permission of some sort and a role name (sometimes...) edited only provides permission and it's not exactly the same ones
For now, I think we need to return strings to avoid issues until GitHub adjusts the API.
@bitwiseman you were entirely right, it's a big mess. My tests didn't show it, I don't know exactly why, maybe it depends on the roles/repositories or if you are using GH or GH Enterprise.
I kept the backwards compatibility and did a translation that is as good as possible.
Unfortunately, I have a user who is blocked by this so if it makes sense to you and you think it goes in the right direction, I would appreciate it being merged and if you could release a new release (sorry I know it's annoying but this inconsistency is really problematic and it was hard to figure it out :/).